bemuse icon indicating copy to clipboard operation
bemuse copied to clipboard

Updates usage of `co` to async function in src/scintillator/index.spec.js

Open 511V41 opened this issue 6 years ago • 2 comments

fixes #636

P.S. I'm glad to committing to Bemuse because I'm beatmania IIDX player in Japan :)

Changelog

Migrate part of the code from co to async functions

511V41 avatar Oct 03 '19 13:10 511V41

I think that we can ignore issues that is raised by codeclimate. It saying "Similar blocks of code found in 2 locations. Consider refactoring" but they are obvious no problem.

ghost avatar Oct 03 '19 14:10 ghost

Codecov Report

Merging #652 into master will increase coverage by 0.07%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   80.91%   80.99%   +0.07%     
==========================================
  Files         156      156              
  Lines        4757     4782      +25     
  Branches      184      184              
==========================================
+ Hits         3849     3873      +24     
- Misses        859      860       +1     
  Partials       49       49
Impacted Files Coverage Δ
src/scintillator/index.spec.js 99.6% <100%> (-0.4%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 30dbbe2...3b9b717. Read the comment docs.

codecov-io avatar Oct 22 '19 12:10 codecov-io

Closing as I just realized that this PR has already been cherry-picked into master — df0e85a918a261d0af15e50a01251c9e50cede88

dtinth avatar Oct 19 '22 20:10 dtinth