Benjamin M. Schwartz

Results 125 comments of Benjamin M. Schwartz

I think `ParamECHConfig` should probably be `ParamECH` to match the parameter's registered display name (which changed from "echconfig" to "ech" before publication). @sftcd This API treats the SvcParamValue as opaque...

> > I'm a little bit uncomfortable about using a map here, since it's going to be a bit less efficient (we'll always need to copy and sort the keys...

@neild Could you clarify: are you proposing that `pack()` would sort SVCBRecord.Params in-place, or sort a copy?

Hi @Amin2460. This app is currently short-staffed, but if you'd like to contribute uTLS integration please feel free. Note that uTLS integration would only help with usage of DoH servers...

> Nice! We should probably update the examples, etc too OK, done

I've added this to #2821 in the context of HTTP CONNECT. I don't think this mitigation makes sense for Upgrade, because there is no widely deployed vulnerable client that would...

The text now reads: > To mitigate the impact of such vulnerable clients, proxy servers MAY close the underlying connection when rejecting an HTTP/1.1 CONNECT request @ekinnear voiced a concern...

Settled on a MUST with some conditions, per advice from the WG session at IETF 122.

> Tun2socks stack will supposedly call udpHandler.Close() when the app socket is closed. No, tun2socks has no way to know whether the app socket has been closed. It only has...