bem-core icon indicating copy to clipboard operation
bem-core copied to clipboard

i18n: tech for ENB

Open aristov opened this issue 9 years ago • 11 comments

We need to implement ENB techs as described in #576 and in branch issues/576@v3

aristov avatar Mar 20 '15 14:03 aristov

cc @veged @narqo @dfilatov

aristov avatar Mar 20 '15 14:03 aristov

@blond ping

aristov avatar May 14 '15 15:05 aristov

WIP — https://github.com/blond/enb-bem-core-i18n

blond avatar May 14 '15 15:05 blond

@blond do you have any time estimates?

veged avatar May 14 '15 16:05 veged

@veged one week

blond avatar May 14 '15 16:05 blond

@blond is there anything to look at?

narqo avatar Jun 10 '15 17:06 narqo

@narqo the ball is on my side: I promised to look and try enb-bem-core-i18n, but just start to do this. I'll be glad to receive any help if possible.

aristov avatar Jun 10 '15 18:06 aristov

@aristov, Now we are making these changes to the enb-bem-i18n package in 1.x branch.

blond avatar Jun 10 '15 20:06 blond

I've created enb-bem-i18n-test branch with simple config and special i18n testing bundle. Everything works fine, but I'm not sure, that I build ?.{lang}.js files properly. @blond, could you check if I do things right, please?

aristov avatar Jun 18 '15 17:06 aristov

@aristov, it looks good.

Some comments:

Instead of ./techs/i18n-bemjson-to-html tech need use enb-bemxjst/techs/bemjson-to-html.

For merge client JavaScript files with i18n need use option lang: '{lang}':

nodeConfig.addTech([require('enb/techs/file-merge'), {
    lang: '{lang}',
    sources : ['?.pre.js', '?.i18n.{lang}.js'],
    target : '?.pre.{lang}.js' 
}]);

blond avatar Jun 19 '15 22:06 blond

If everything is done, we can release the new package version to use it in #1108.

aristov avatar Jul 23 '15 19:07 aristov