libsmc

libsmc copied to clipboard

I believe a shift sign has been inverted rendering the conversion incorrect. ``` static unsigned int from_fpe2(uint8_t data[32]) { unsigned int ans = 0; // Data type for fan calls...

yackx

In the Swift version, there's an uint16_t padding between keyInfo and result: https://github.com/beltex/SMCKit/blob/v0.0.13/SMCKit/SMC.swift#L473-L475 That seems to be missing in the C version: https://github.com/beltex/libsmc/blob/master/src/smc.c#L193-L194

floe

beltex

beltex

- Use of test framework TBD - https://github.com/vmg/clar

beltex

beltex

- Javadoc like - Possibilities: [Doxygen](http://en.wikipedia.org/wiki/Doxygen), [Docurium](https://github.com/libgit2/docurium)

beltex

- See https://github.com/beltex/swift-smc/issues/2 for discussion - Can give the option for auth via `AuthorizationExecuteWithPrivileges()` for convenience as it still seems to be available via C

beltex

- For convenience - Possibly use CMake

beltex