John Belmonte

Results 106 issues of John Belmonte

What kind of issue is this? - [x] **Feature Request**. Start by telling us what problem you’re trying to solve. Often a solution already exists! Don’t send pull requests to...

enhancement
integration

Message implements only `__eq__`, so for example `msg_a == msg_b` and `msg_a != msg_b` can both yield `True`. https://github.com/olemb/mido/blob/e87384d7e5d62de361a65ab6b1d5d62750475e84/mido/messages/messages.py#L68 https://www.python.org/dev/peps/pep-0008/#programming-recommendations > When implementing ordering operations with rich comparisons, it is...

Is it intentional that a double can't be compared to an integer literal? ``` if plus >= 0: ^ compiler.errors.TypedSyntaxError: can't compare double to Literal[0] ```

staticpython
sp-correctness

``` $ docker run -v $PWD:/vol -it --rm ghcr.io/facebookincubator/cinder-runtime:cinder-3.8 -X jit -m compiler --static vol/autogen_bug.py JIT: /cinder/src/Jit/codegen/autogen.cpp:143 -- assertion failed: func != nullptr No pattern found for opcode Fadd: Xxr...

staticpython
sp-correctness

good (no options): ``` $ docker run -v $PWD:/vol -it --rm ghcr.io/facebookincubator/cinder-runtime:cinder-3.8 vol/cinder_typed_prim_bug.py done 0.57 ``` bad (`-X jit -m compile --static`): ``` $ docker run -v $PWD:/vol -it --rm...

staticpython
sp-correctness

I noticed that `force_compile()` fails if the function isn't in the jit list. Would it be reasonable to change that behavior? Example use case: I'd like to enable jit on...

cinder-jit

From my understanding, starting cinder with `-X jit` will compile everything it encounters until `cinderjit.disable()`, but by then a bunch of things may already be compiled. An option to start...

cinder-jit

When I build Cinder and run the programs in Tools/benchmarks, the static and static_basic variants seem to be slower than the originals. Am I doing something wrong? (update: -X jit...

staticpython

(and there is an exception while assembling the error message) ```python def test(x: double, y: double) -> double: return x ** y ``` ``` File "/usr/lib/python3.8/compiler/visitor.py", line 70, in visit...

staticpython
sp-correctness

The `-X jit-enable-jit-list-wildcards` option causes overhead of `PyEntry_init` to increase by 4x. The following are measured with `prof top -g -p ...` on my app process. empty jit list, wildcards...

cinder-jit