John Belmonte

Results 252 comments of John Belmonte

> I had a similar error, since the 3.11 branch did not exist in my local repo. I had to first create the branch with git switch 3.11 (which then...

> I got this error and now I cannot get it to go away. Tried adding the remote tracking branches which didn't help. Tried completely removing the backport branch and...

It seems like the size of segments is dictated by the number of children and size of text label for each child. To compensate, color is used to indicate relative...

I was surprised that there doesn't seem to be a PEP-like process for stdlib additions. You just open an issue with some patches, and a few people on a thread...

Looking at the code, it seems like this can only happen by Broken/ClosedResourceError. (`_abort_web_socket()` makes a 1006 without a reason string). https://github.com/HyperionGray/trio-websocket/blob/da7e5fa32b12d241fa9ba2f01d9b682e88f4e1d5/trio_websocket/_impl.py#L1251-L1256

It's due to the `strict_exception_groups=True` default. I'm not sure what to do, because `strict_exception_groups=True` code is not really compatible with `strict_exception_groups=False` code (nor with code using trio versions predating the...

summary: trio-websocket is not "safe" to use with `strict_exception_groups=True`. It will require manual review of the code and manual testing, as well as migration to exception groups.

This is really about trio-websocket's support for trio nurseries always raising ExceptionGroup. The only reasonable way for packages and applications to deal with that is by using the new exception...

Thank you for investigating that problem. I'm not a fan of blacken formatting*, but the plea I'll make is that making a huge formatting change is not ideal for a...