selective_search_py
selective_search_py copied to clipboard
Problem with including boost in CMakeLists.txt
Hello:
Just a suggestion. Boost should be included in CMakeList.txt in a more generic way:
find_package( Boost COMPONENTS python system REQUIRED )
include_directories(${Boost_INCLUDE_DIRS})
link_directories(${Boost_LIBRARY_DIR})
instead of
set(BOOST_LIBS "-lboost_system -lboost_python3")
Otherwise on some systems it throws a linker error:
/usr/bin/ld: cannot find -lboost_python3
.
I'd create a pull request but sadly I still haven't solved problems with Boost.Numpy (https://github.com/ndarray/Boost.NumPy/issues/43).