bf_atof_internal should check `USE_BF_DEC` macro before using bfdec_normalize_and_round

Open laishere opened this issue 1 year ago • 2 comments

When I tried to compile quickjs, I found there's a missing macro check in bf_atof_internal function. https://github.com/bellard/quickjs/blob/36911f0d3ab1a4c190a4d5cbe7c2db225a455389/libbf.c#L3110

bfdec_normalize_and_round is defined under USE_BF_DEC flag, and bf_atof_internal trys to access it without the same flag.

Jun 28 '24 15:06 laishere

Thank you for reporting this. I shall fix this bug shortly.

Jun 28 '24 15:06 chqrlie

I think this issue hasn't been fixed yet. I made a simple fix, I'm not sure if it's the same as your fix. You can take a look https://github.com/bellard/quickjs/pull/354 for details. @chqrlie

Sep 19 '24 05:09 HarlonWang

libbf.c was removed.

Mar 18 '25 19:03 bellard