quickjs icon indicating copy to clipboard operation
quickjs copied to clipboard

Small fixes and additional functions

Open zestyBug opened this issue 1 year ago • 3 comments

Hi, I have been using QuickJS as a wrapper for a long time. these are the fixed I have made.

  • I used raw string access to avoid additional memory allocation
  • also new string allocate function for acts like JS_NewArrayBuffer

zestyBug avatar Mar 13 '24 21:03 zestyBug

Hello @zwarrior1,

Thank you for contributing. I cannot merge your patch as posted but will apply your patches with attribution after some adjustments. See my comments inline.

Chqrlie.

chqrlie avatar Mar 22 '24 08:03 chqrlie

I'd love to see this broken down into smaller, focused PRs since the changes don't depend on each other.

saghul avatar Mar 22 '24 09:03 saghul

I'd love to see this broken down into smaller, focused PRs since the changes don't depend on each other.

Of course. But given the change requests, I am going to do this myself.

chqrlie avatar Mar 22 '24 10:03 chqrlie