Maksim Beliaev

Results 56 comments of Maksim Beliaev

@PietroPasotti in your example you use `return`, which will not work in nested structures. and I am afraid that just going immediately with system exit will non handle any storage...

Hi @benhoyt Question here would be if we preserve the same code structure for the next ten years or not, because if we educate users to exit by themselves, then...

in proposed PR we either face an error while committing and then non-zero happens and we end up in ErrorState, which most probably makes sense or if commit is successful,...

what is about? considering that sys.exit will be caught by the `main` ```python def exit(self, commit: bool = True): """Stop the execution of the framework and exit.""" if commit: self.commit()...

@PietroPasotti @benhoyt what do you think about implementation as in https://github.com/canonical/operator/issues/839#issuecomment-1318370421 ?

@benhoyt I will add it as part of sdk tutorial and also add "how to" section on juju.is I will let you review it once ready

this should be resolved by sidecar rewrite. Not taking action until rewrite

+1 really annoying in meantime the workaround in case you are fine with TD placement is to create a hidden block and hidden link ```mermaid graph TD classDef hidden display:...

I think it is a backwards incompatible change. Can we provide an option for case sensitive/insensitive?

I think I am good with proposal However, based on semantic versioning we need to make breaking changes only in major bump, eg 1.x.x