belav
Run on save being disabled in Rider plugin causes toil
We're very happily using CSharpier in a large engineering organization. We have many .NET services living in different repositories, meaning the average developer is regularly checking out new repos. "Run on save" is disabled by default in the Rider plugin and it uses Rider's layered configuration, so settings are only stored per solution and it's not possible to globally enable run on save once and forever.
For us this means we regularly have developers committing unformatted code when they check out a new repository and forget to enable run on save. These mistakes are caught in CI, but they happen frequently and lead to unnecessary frustration.
I see two ways to make this a better experience:
- Enable run on save by default. This makes sense to me, because I expect most people installing a code formatter plugin would want it to automatically format their code. It's also incredibly easy to implement, so I made a PR in case you think this would be a good idea https://github.com/belav/csharpier/pull/1738
- Make it possible to globally configure the plugin, not only on a solution level. I'm not familiar with how the layered configuration has to be implemented to allow this.
Thanks for this amazing tool, it's a great developer experience booster :)
Enable run on save by default. This makes sense to me, because I expect most people installing a code formatter plugin would want it to automatically format their code. It's also incredibly easy to implement, so I made a PR in case you think this would be a good idea https://github.com/belav/csharpier/pull/1738
I think that would probably frustrate more people that it benefits. VSCode, prettier plugins, etc - they all seem to be opt in for format on save.
Make it possible to globally configure the plugin, not only on a solution level. I'm not familiar with how the layered configuration has to be implemented to allow this.
I'm on board with this and didn't even realize it didn't work that way until I tested it just now. I may have missed something when I implemented the settings that is required to allow them to be stored in the "this computer" layer.
Got it, will close the PR then. Making it globally configurable would be much appreciated, after all it already works this way for the Visual Studio plugin.