VSCode 1.9.0 - Diagnostics always showing even when ext is not the formatter
Environments
- IDE Version: vscode 1.95
- Extension Version: 1.9.0
- CSharpier Version: 0.30.3 will NOT be the same as the extension version
- Operating System: windows 11
- .csharpierrc Settings: none
- .editorconfig Settings: none
Log Output
Steps to reproduce
- Install csharpier dotnet tool globally
- Install vscode extension
- Do not make csharpier the default formatter
- Open a project
- Open a cs file
Expected behavior
When CSharpier is not the selected formatter, no diagnostics should show up.
When adopting CSharpier, not all repositories will have CSharpier setup.
Actual behavior
CSharpier diagnostics shows up (seems related to this commit
I've added an option to disable this for now. I think It makes sense to disable these diagnostics when csharpier is not the formatter.
@badsyntax do you happen to know how to find the current formatter? I was thinking it would be quick to make this change but wasn't able to track down how to get that information in an extension.
This is awesome! I think keeping the option in the long run might even be a good thing. For the little I saw the result, is really was in my way.
@belav I'll take a look later this week
Nice solution. I agree with @scabana that the option should be left.