csharpier icon indicating copy to clipboard operation
csharpier copied to clipboard

csharpier as msbuild dependency doesn't fail the github action anymore

Open OneCyrus opened this issue 4 months ago • 1 comments

Environments:

  • CSharpier Version: 0.29.2
  • Running CSharpier via: dotnet
  • Operating System: Ubuntu 22.04
  • .csharpierrc Settings:
  • .editorconfig Settings:

Steps to reproduce:

dotnet build --configuration Release /p:CSharpier_LogLevel=Error

Expected behavior:

we are running csharpier as msbuild dependency and want the build to fail of the code is not formatted. it used to work before but currently even when an error is detected the build succeeds and the github action workflow doesn't fail.

formatting error is detected correctly:

Error /home/runner/work/automation-data/automation-data/Poseidon/Poseidon/GqlSchema/ITSM/Itsm.cs - Was not formatted.
    ----------------------------- Expected: Around Line 1 -----------------------------
    using System.Linq.Expressions;
    using System.Reflection;
    ----------------------------- Actual: Around Line 1 -----------------------------
    using Aveniq.Poseidon.GqlSchema.CMDB;
    using Aveniq.Poseidon.GqlSchema.SMDB;

build fails:

Build failed.

    0 Warning(s)
    1 Error(s)

Actual behavior:

build succeeds and the exit code doesn't fail the github action job.

Build succeeded.

    0 Warning(s)
    0 Error(s)

OneCyrus avatar Oct 09 '24 11:10 OneCyrus