csharpier icon indicating copy to clipboard operation
csharpier copied to clipboard

charpier do not repect `#pragma warning disable format`

Open heartacker opened this issue 1 year ago • 8 comments
trafficstars

csharp supports this

#pragma warning disable format
#pragma warning enable format

heartacker avatar Apr 13 '24 08:04 heartacker

any updates

heartacker avatar Jan 12 '25 08:01 heartacker

It seems a bit unnecessary to support a second method of disabling formatting. Is there some benefit that I'm missing?

belav avatar Jan 12 '25 13:01 belav

This is the way of official support, and I think it should be supported.

heartacker avatar Jan 12 '25 14:01 heartacker

https://github.com/dotnet/roslyn/issues/36930#issuecomment-530441099

FYI

heartacker avatar Jan 12 '25 14:01 heartacker

https://stackoverflow.com/a/65083158

heartacker avatar Jan 12 '25 14:01 heartacker

https://developercommunity.visualstudio.com/t/%E5%A6%82%E4%BD%95%E9%98%B2%E6%AD%A2vs-%E6%A0%BC%E5%BC%8F%E5%8C%96%E6%88%91%E7%9A%84%E6%9F%90%E5%87%A0%E8%A1%8C%E4%BB%A3%E7%A0%81%EF%BC%9F-%E6%AF%94%E5%A6%82c-c-%E7%9A%84%E5%87%A0%E8%A1%8C%E4%BB%A3%E7%A0%81%EF%BC%9F/789307

heartacker avatar Jan 12 '25 14:01 heartacker

https://developercommunity.visualstudio.com/t/%E5%A6%82%E4%BD%95%E9%98%B2%E6%AD%A2vs-%E6%A0%BC%E5%BC%8F%E5%8C%96%E6%88%91%E7%9A%84%E6%9F%90%E5%87%A0%E8%A1%8C%E4%BB%A3%E7%A0%81%EF%BC%9F-%E6%AF%94%E5%A6%82c-c-%E7%9A%84%E5%87%A0%E8%A1%8C%E4%BB%A3%E7%A0%81%EF%BC%9F/789307#T-N818996

heartacker avatar Jan 12 '25 14:01 heartacker

I understand that VS supports it. If someone is using CSharpier I don't see why they would ask VS to format a file, which is why it seems unnecessary to me.

I'm not opposed to supporting it so feel free to submit a PR.

belav avatar Jan 12 '25 15:01 belav