Christian Beikov

Results 516 comments of Christian Beikov

Thanks for your work. I simplified and cleaned up the code. Superseded by https://github.com/hibernate/hibernate-orm/pull/8514

I'll close the PR and Jira issue unless you can explain more clearly why you need this. You are in control of the dialect @Huo662329, so why don't you override...

Thanks for the work. I figured there were some nullability issues and did a proper fix in https://github.com/hibernate/hibernate-orm/pull/8638

I'll assume this is simply stale and close it

Could you please use construct a `DateTimeFormatter` as static variable, that has an optional time part?

Thanks for your work. I'll try to get this through the finish line as part of https://github.com/Blazebit/blaze-persistence/pull/1911

A much simpler solution would be to change the registration from `CapacityDependentDdlType.builder( FLOAT, "float($p)", this )` to `CapacityDependentDdlType.builder( FLOAT, "float", this )` since the documentation clearly states that the precision...

> > A much simpler solution would be to change the registration from `CapacityDependentDdlType.builder( FLOAT, "float($p)", this )` to `CapacityDependentDdlType.builder( FLOAT, "float", this )` since the documentation clearly states that...

We could do the same simplification for e.g. PostgreSQL since the parametrizations of `float` are essentially just aliases as well according to [its documentation](https://www.postgresql.org/docs/current/datatype-numeric.html#:~:text=PostgreSQL%20also%20supports%20the,mean%20double%20precision.).

>It sounded like you were suggesting that one-line change as an alternative simpler solution instead of the whole patch. But I probably misunderstood your comment. I am suggesting to that...