Christian Beikov

Results 516 comments of Christian Beikov

> And I don't think primitive arrays make sense because it's pretty hard for us to validate that a `Selection` is non-null. If users requests an `int[]` as result type,...

Please also add a test that reproduces the problem to the test class `org.hibernate.orm.test.flush.NonTransactionalDataAccessTest`.

Please rebase and squash to a single commit

Sorry this takes so long, but please understand that the ORM team has it's own priorities and is [not that huge](https://github.com/hibernate/hibernate-orm/wiki/Huge-Project,-Small-Team) to respond to every request so fast. We're all...

I already merged it on main. @dreab8 the change of this PR is fine IMO, because `doExecuteUpdate()` is only ever called from `executeUpdate()` which already does the following: ```java getSession().checkTransactionNeededForUpdateOperation(...

I'm fine with the approach, but you'll probably have to align this with `org.hibernate.engine.jdbc.connections.internal.BasicConnectionCreator#convertSqlException` and adapt `ConnectionCreatorTest` accordingly.

Thanks, but the proper fix would be to return `null` if the string is `null`. Can you please change that? Then we can merge this.

Superseded by https://github.com/hibernate/hibernate-orm/pull/7939 and https://github.com/hibernate/hibernate-orm/pull/7940

If an anchor is wrong, I agree to remove/replace it, but let's be sensible here, links to these sections (e.g. https://docs.jboss.org/hibernate/orm/5.0/userguide/html_single/Hibernate_User_Guide.html#collections-set) have used these anchors for quite some time and...

Thanks for your attempt to contribute, but please create a fresh PR against the `main` branch and include a test case that provokes this bug.