Behdad Esfahbod comments

Results 1487 comments of


                                            Behdad Esfahbod

Expose host fontconfig conf.d?

I have no opinion or comments.

Issues in getKerningPairsFromOTF.py

Fixed `_ClassDef_invert()`: https://github.com/fonttools/fonttools/issues/939

Is skipping ValueFormat1 == 0 in class kerning correct?

It's possible that ValueFormat2 is nonzero, which means second glyph in pairs is adjusted but no first glyph.

Is skipping ValueFormat1 == 0 in class kerning correct?

Then yes, that's a degenerate subtable. Is Coverage empty as well?

Is skipping ValueFormat1 == 0 in class kerning correct?

Then that subtable will act as a stopper. Anything on the coverage gets a zero there and next subtables will NOT be search for those glyphs as the first in...

Is skipping ValueFormat1 == 0 in class kerning correct?

Not arguing with that :).

Is skipping ValueFormat1 == 0 in class kerning correct?

I also like to see the font. I read the code and found a few different issues. Filing new issue now.

Is skipping ValueFormat1 == 0 in class kerning correct?

For reference: https://github.com/adobe-type-tools/kern-dump/issues/2

[spec] Variable FEA Syntax

I feel like the `variation` keyword is confusing. Why not just stick with `feature` and add conditionset?

[spec] Variable FEA Syntax

I know I wasn't at the meeting that this was discussed. But I've been thinking about the proposed syntax and I *highly* encourage you to reconsider a couple of things....