Behdad Esfahbod comments

Results 1486 comments of


                                            Behdad Esfahbod

objects returned by hb_directwrite_face_create aren't usable

> I see font->serial, and I guess callers are expected to stash the serial and check it every now and then. But does harfbuzz clear font->data.coretext when the serial is...

objects returned by hb_directwrite_face_create aren't usable

> Directwrite doesn't need it because the shaper just uses the font scale at shape time That's because we always position at font UPEM size and scale linearly. And variations...

Whitespace and USE dotted circles

> Is this by design? I don't think so.

Whitespace and USE dotted circles

Oops. That's because: ``` export O↦ = 0; # OTHER ``` and: ``` symbol_cluster = (O | GB) tail?; ``` @dscorbett I think the `O` there is wrong. WDYT?

Whitespace and USE dotted circles

The spec says instead of `O` there should be there: ``` UGC = So except U+25CC; UGC = Sc ```

Whitespace and USE dotted circles

I'm fine separating U+0020 only. Should we do the same in other syllabic shapers as well?

Insert dotted circle before applying GSUB in USE

Thanks Norbert. @dscorbett would you have time to look into this by any chance?

Insert dotted circle before applying GSUB in USE

> A font can currently distinguish between a dotted circle present in the input and a dotted circle inserted by the shaper. If the shaper’s cluster model is wrong, the...

Insert dotted circle before applying GSUB in USE

I mean.. other than the changing of behavior which would make targeting harder.

Harfbuzz is broken with --fatal-meson-warnings

> I have proposed to make meson behave the same way as autotools: > > * no error at configure time, but record whether ragel was found > > *...