Behdad Esfahbod
Behdad Esfahbod
Thanks for sorting this out. We use `strtof` twice in `util/helper-subset.hh`. I'm not sure which solution is preferred: to change the test runtime to enforce locale=C, or change the parsing...
> There is another place where the output is made sure to be in locale=C and one where a comma is replaced by a dot after the fact, so maybe...
But those two pieces of code are for printing a double, not parsing it. Those two are in the library code. We don't control what locale client runs under. I'll...
> > But those two pieces of code are for printing a double, not parsing it. > > Yes those 2 are printing doubles in C format, so maybe the...
> You mean factoring `parse_axis_position ` out to a new `hb_subset_axis_range_from_string`? Yes. > At least there the range struct could be used as it is a private/unexported function so no...
> To move the problematic code from util/ to the subset library under `hb_subset_axis_range_from_string()` And for the sake of completeness, a `hb_subset_axis_range_to_string()`.
> I can work on this when I return from vacation, this week might be too tight for me.:) No rush. :)
@qxliu76 Friendly reminder. Thanks.
> I'm starting to work on this. I think there would be a change in the command line parameter: previously either "," or " " could be used as delimiter,...
> we use `s = strtok(NULL, ", ")` to separate axis parameters, and then parse each axis positions. If the axis position string could have comma, then it'll be hard...