welcome
welcome copied to clipboard
I got welcomed for my first issue, but it wasn't my first issue
https://github.com/electron/electron/issues/13969#issuecomment-411127883
Previously, https://github.com/electron/electron/issues/12631
Thanks for the issue @nornagon. I actually had another report of this in the electron org a while back, and I wonder if the GH API is struggling with the volume of issues there?? I can't think of an issue on this app's end honestly. The code for the app is really simple: https://github.com/behaviorbot/new-issue-welcome/blob/master/index.js
Maybe that you created the issue from a project board somehow made things weird?
Anyways, I'll leave this issue to track any other repeats of this, but can't think of an immediate solution
Happened again! https://github.com/electron/electron/issues/14679
Aha! I thought it was odd the 2 people who reported this were high volume contributors.
Currently the code filters out PRs, but doesn't iterate through pages of results. But you could have a page of 29 PRs and 1 issue but have other issues in older pages.
The solution is to update the code to use the search API to get a more accurate query. I actually do this in one of the three welcomes:
const res = await context.github.search.issues({q: `is:pr is:merged author:${creator} repo:${owner}/${repo}`})
But not the other two 🤷♀️
Thanks for reporting this! I'll put it on my to-do list :)
This happened to me last week as well, should have reported it 😄
Got my third first issue today! https://github.com/electron/electron/issues/15253#issuecomment-431118457
It seems that this only happens when the other issues have been deleted, making the new one your only -- "first" -- PR or issue. Supply more data if this doesn't appear to be the case.
@Temerold electron/electron#15253 very much wasn't my only non-deleted issue on electron/electron at the time I created it.
Weird... Edit: Sorry! Didn't read hiimbex's reply.
This happens to us in https://github.com/orchest/orchest/ from time to time as well. For example:
- Bot welcoming actual first issue by @iannbing: https://github.com/orchest/orchest/issues/615#issuecomment-1000830476
- Bot welcoming @iannbing again: https://github.com/orchest/orchest/issues/803#issuecomment-1069359146
- And again: https://github.com/orchest/orchest/issues/1075#issuecomment-1171605566
Do you have any idea what might be happening here? This is our config.