request-info
request-info copied to clipboard
Silently fails without a .github/config.yml file
👋 I've noticed that this silently fails (doesn't post a comment) if the repository doesn't have a .github/config.yml
file.
I'm not sure how probot-config
works, but looking at it I'd guess that it returns that defaultConfig
if both the file and the file in a .github
repository don't exist:
https://github.com/behaviorbot/request-info/blob/c2451414a34a26b1b4049dc102d2e7137b9df714/index.js#L24
Instead its returning null
, which results in an error log:
TypeError: Cannot read property 'requestInfoOn' of null
at receive (/app/index.js:26:19)
at process._tickCallback (internal/process/next_tick.js:68:7)
event: {
--
"id": "123",
"event": "issues.opened",
"repository": "JasonEtco/tests",
"installation": 123
}
cc @hollenberry
Thanks for opening this issue, a maintainer will get back to you shortly!