request-info icon indicating copy to clipboard operation
request-info copied to clipboard

Published 20 hours ago • verified publisher icon behaviorbot

Comments on trivial changes

Open strugee opened this issue 6 years ago • 4 comments

See https://github.com/probot/metrics/pull/14#issuecomment-348615845 for an example of this - it's just a typo fix so I didn't provide a body.

strugee avatar Dec 01 '17 21:12 strugee

Thanks for opening this issue, a maintainer will get back to you shortly!

welcome[bot] avatar Dec 01 '17 21:12 welcome[bot]

Sorry for the delay in getting back on this, but yes don't disagree that this sucks. Would happily review and merge a PR to check for the commit diff and anything less than a specified amount of lines in the config file (ie 5), the bot would not comment.

hiimbex avatar Apr 16 '18 02:04 hiimbex

@hiimbex I'll like to work on this

itaditya avatar Apr 16 '18 16:04 itaditya

@hiimbex, I was thinking about the possible solutions. One quick and dirty way would be to just check the count of characters in the diff file. This method does have it's flaws, like renaming file can be a big deal however the diff char count will be small in this case.

I think I'll first make a basic version with this method and then improve upon it .

itaditya avatar Apr 16 '18 20:04 itaditya