beeware
Is the checkstyle job on CI broken?
Running ant checkstyle locally now generates errors:
Buildfile: /Users/uranusjr/Documents/programming/python/voc/voc/build.xml
checkstyle:
[checkstyle] Running Checkstyle 6.19 on 133 files
[checkstyle] [ERROR] /Users/uranusjr/Documents/programming/python/voc/voc/python/common/org/python/types/Range.java:75:86: 'typecast' is not followed by whitespace. [WhitespaceAfter]
[checkstyle] [ERROR] /Users/uranusjr/Documents/programming/python/voc/voc/python/common/org/python/types/Range.java:91:51: 'typecast' is not followed by whitespace. [WhitespaceAfter]
[checkstyle] [ERROR] /Users/uranusjr/Documents/programming/python/voc/voc/python/common/org/python/types/Range.java:185:69: 'typecast' is not followed by whitespace. [WhitespaceAfter]
[checkstyle] [ERROR] /Users/uranusjr/Documents/programming/python/voc/voc/python/common/org/python/types/Slice.java:39:38: 'typecast' is not followed by whitespace. [WhitespaceAfter]
[checkstyle] [ERROR] /Users/uranusjr/Documents/programming/python/voc/voc/python/common/org/python/types/Slice.java:46:42: 'typecast' is not followed by whitespace. [WhitespaceAfter]
[checkstyle] [ERROR] /Users/uranusjr/Documents/programming/python/voc/voc/python/common/org/python/types/Slice.java:63:19: Use a single space to separate non-whitespace characters. [SingleSpaceSeparator]
[checkstyle] [ERROR] /Users/uranusjr/Documents/programming/python/voc/voc/python/common/org/python/types/Slice.java:63:45: 'typecast' is not followed by whitespace. [WhitespaceAfter]
[checkstyle] [ERROR] /Users/uranusjr/Documents/programming/python/voc/voc/python/common/org/python/types/Slice.java:80:43: 'typecast' is not followed by whitespace. [WhitespaceAfter]
BUILD FAILED
/Users/uranusjr/Documents/programming/python/voc/voc/build.xml:31: Got 9 errors and 0 warnings.
Total time: 2 seconds
None of those are reported by the CI. I don’t have enough knowledge on either Ant, Checkstyle, or Beekeeper, but this smells wrong to me…
Great spot! Yes, I do see that from ant checkstyle on current master (862b4ed9) and the latest PR commit before that (fcb5df71)!
I initially thought this is due to the checks not being run properly in #630 before merge, but the Slice.java lines are from #629, and Beekeeper reports the task passed. I can confirm that ant checkstyle on e6a70a27 returns errors.
cc @freakboy3742 – I think the LINT_OUTPUT in javacheckstyle Beefore check is the issue, it's parsing
[checkstyle] [ERROR] /Users/cflee/Projects/voc-dev/voc/python/common/org/python/types/Slice.java:80:43: 'typecast' is not followed by whitespace. [WhitespaceAfter]
into the filename .../python/common/org/python/types/Slice.java:80 and taking the column number 43 as the line number.
Sorry, I don't have time to figure out Beefore's local setup tonight to make a PR, but maybe this will save you some time...
Actually, there seems to be another issue apart from pybee/beefore#14 that I just opened -- if you look at #706, javacheckstyle is passing on db27983 even though the if statement doesn't have a space before the opening curly brace.