Exclude display=NONE nodes from layout

Open HalfWhitt opened this issue 9 months ago • 2 comments

Fixes #3322
Fixes #1502... I think. There are a number of things going on there, but if I'm reading it correctly, I think this is the last part remaining.

I've parametrized display into the existing tests for visibility, and added a new test to verify that a non-displayed widget is removed from the layout. I'm not entirely sure if it's sufficient, or if there are layout situations that could behave differently and should be tested as well.

PR Checklist:

[x] All new features have been tested
[x] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

Apr 03 '25 03:04 HalfWhitt

@freakboy3742 Can you think of other ways this can/should be tested, or does this seem good enough?

Apr 04 '25 01:04 HalfWhitt

Not sure why I closed this — pretty sure I only meant to mark it as draft.

Jun 07 '25 05:06 HalfWhitt