beets icon indicating copy to clipboard operation
beets copied to clipboard

Update poetry command

Open Serene-Arc opened this issue 3 weeks ago • 5 comments

I was getting my development environment set up so I could start contributing code again (yay!) when I noticed that the docs are out of date. poetry shell is no longer part of the core poetry tool, but a plugin. Using poetry env activate is given as a replacement. This just updates the docs to reflect that. I also added a shortcut so people could understand how to install all the extras, since that's pretty necessary for developers.

  • [ ] Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • [ ] Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • [ ] Tests. (Very much encouraged but not strictly required.)

Serene-Arc avatar Dec 06 '25 03:12 Serene-Arc

I think before we'd change this, we would want to look into bumping our poetry version above v2. We're still specifying poetry <2.0 which means that the poetry shell command would still be the recommended way to set up the environment.

henry-oberholtzer avatar Dec 06 '25 22:12 henry-oberholtzer

I think before we'd change this, we would want to look into bumping our poetry version above v2. We're still specifying poetry <2.0 which means that the poetry shell command would still be the recommended way to set up the environment.

Indeed, @Serene-Arc see https://github.com/beetbox/beets/issues/5783 for the context.

snejus avatar Dec 06 '25 22:12 snejus

@snejus @wisp3rwind perhaps it's time to try a switch to uv, or perhaps implementing a fix to the issue in #5783 at least? Is there any particular reason it's not moved forwards at all? I would prefer using it over poetry and pipenv and I'm willing to investigate the integration (and this isn't a real reason, but I do so enjoy supporting rust tools).

Serene-Arc avatar Dec 07 '25 02:12 Serene-Arc

@snejus @wisp3rwind perhaps it's time to try a switch to uv, or perhaps implementing a fix to the issue in #5783 at least? Is there any particular reason it's not moved forwards at all? I would prefer using it over poetry and pipenv and I'm willing to investigate the integration (and this isn't a real reason, but I do so enjoy supporting rust tools).

Tbh, I’d also prefer using uv, but there are a few arguments against adopting it right now, mainly that it would further segregate our development env across the various subpackages. Still, if you want to evaluating a uv-based setup for beets, you can take a look at https://github.com/beetbox/mediafile/pull/87, which replaces poetry & pipx with uv in the mediafile package. It may serve as a useful reference point.

semohr avatar Dec 07 '25 11:12 semohr

The reason why we pinned poetry is here: https://github.com/beetbox/beets/issues/5770

snejus avatar Dec 07 '25 14:12 snejus