library: add subtitle (id3 TIT3) field
Description
Adds support for a subtitle field, corresponding to the TIT3 id3 tag. Requires beetbox/mediafile#82
I don't think tests are required for this - I can't really see a comprehensive test suite for all available fields - but I might be wrong.
I'll add the changelog entry after your review.
To Do
- [x] Documentation. (If you've added a new command-line flag, for example, find the appropriate page under
docs/to describe it.) - [x] Changelog. (Add an entry to
docs/changelog.rstto the bottom of one of the lists near the top of the document.) - [ ] Tests. (Very much encouraged but not strictly required.)
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.
The musicbrainz plugin should also be updated to pull the field and populate it as well.
Did this addition stall? Seems increasingly commonly used with Picard and now Navidrome’s metadata enhancements.
Did this addition stall?
I don't know... there are frequent commits on the main branch but some PRs are ignored. There must surely be a reason but the core devs would have to share that. Or they simply forgot about this :-)
I added a changelog entry.
Aw snap just realised this depends on an unmerged PR in mediafile repo :/
I just merged https://github.com/beetbox/mediafile/pull/82 :upside_down_face:. You up to rebase and revive this?
Rebased!! :rocket:
Awesome! Let me see if I'm able to create a new mediafile version and how to do that :fearful:
I don't think I'm able to do a version bump for mediafile. I raised the issue in our internal chat tho. We will have to wait some more, sorry :see_no_evil:
Hi there! Any luck in releasing a new version of mediafile? We are like a meter from the finish line! :smile:
I'm ready to rebase this whenever needed.
We should be able to do that in the near future :tada: We sill need to create a (maintainable) release workflow but other than that we should be able to create a release.