beets icon indicating copy to clipboard operation
beets copied to clipboard

library: add subtitle (id3 TIT3) field

Open daniele-athome opened this issue 9 months ago • 12 comments

Description

Adds support for a subtitle field, corresponding to the TIT3 id3 tag. Requires beetbox/mediafile#82

I don't think tests are required for this - I can't really see a comprehensive test suite for all available fields - but I might be wrong.

I'll add the changelog entry after your review.

To Do

  • [x] Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • [x] Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • [ ] Tests. (Very much encouraged but not strictly required.)

daniele-athome avatar Mar 28 '25 09:03 daniele-athome

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

github-actions[bot] avatar Mar 28 '25 09:03 github-actions[bot]

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

github-actions[bot] avatar Mar 28 '25 09:03 github-actions[bot]

The musicbrainz plugin should also be updated to pull the field and populate it as well.

Did this addition stall? Seems increasingly commonly used with Picard and now Navidrome’s metadata enhancements.

michaelkrieger avatar Jul 20 '25 04:07 michaelkrieger

Did this addition stall?

I don't know... there are frequent commits on the main branch but some PRs are ignored. There must surely be a reason but the core devs would have to share that. Or they simply forgot about this :-)

daniele-athome avatar Jul 21 '25 12:07 daniele-athome

I added a changelog entry.

daniele-athome avatar Aug 02 '25 18:08 daniele-athome

Aw snap just realised this depends on an unmerged PR in mediafile repo :/

snejus avatar Aug 02 '25 21:08 snejus

I just merged https://github.com/beetbox/mediafile/pull/82 :upside_down_face:. You up to rebase and revive this?

semohr avatar Sep 30 '25 18:09 semohr

Rebased!! :rocket:

daniele-athome avatar Sep 30 '25 18:09 daniele-athome

Awesome! Let me see if I'm able to create a new mediafile version and how to do that :fearful:

semohr avatar Sep 30 '25 18:09 semohr

I don't think I'm able to do a version bump for mediafile. I raised the issue in our internal chat tho. We will have to wait some more, sorry :see_no_evil:

semohr avatar Sep 30 '25 18:09 semohr

Hi there! Any luck in releasing a new version of mediafile? We are like a meter from the finish line! :smile:

I'm ready to rebase this whenever needed.

daniele-athome avatar Oct 15 '25 09:10 daniele-athome

We should be able to do that in the near future :tada: We sill need to create a (maintainable) release workflow but other than that we should be able to create a release.

semohr avatar Oct 15 '25 09:10 semohr