beets icon indicating copy to clipboard operation
beets copied to clipboard

Support non-POSIX text editor file paths for Windows.

Open sgunn80808 opened this issue 3 months ago • 1 comments

Description

Fixes issue with shlex.split parsing Windows editor program file paths as POSIX.

This resulted in the following error for a program located in C:\Program Files when running beet edit

error: could not run editor command 'C:Program': [WinError 2] The system cannot find the file specified

Setting posix = not is_windows changes the default parsing mode of shlex for Windows platform and allows Windows file paths to be used to specify the text editor.

To Do

  • [x] ~Documentation~
  • [x] Changelog
  • [x] ~Tests~

sgunn80808 avatar Mar 11 '24 22:03 sgunn80808

I marked Tests as non-mandatory because I couldn't find a good place to add a test for this change. Please comment here if you have any suggestions for where a test should go and I can add one. Thanks!

sgunn80808 avatar Mar 11 '24 22:03 sgunn80808