beets icon indicating copy to clipboard operation
beets copied to clipboard

Style: candidates list is hard to visually parse

Open ArtemSmaznov opened this issue 4 months ago • 2 comments

Problem

Let me first say that I like the cli UI redesign. This has the potential to making it easier to work with. Unfortunately, I am still having a hard time reviewing the candidates list as it had the following coloring logic:

(white) candidate
(yellow) diff
(white) candidate metadata

This makes the white lines blend together between neighboring candidates.

Example:

screenshot-2024-02-28_17-06-15

I would suggest to make the metadata (i.e. MusicBrainz, CD, Year, Country, etc.) be gray like we now have with the musicbrainz urls (love that part - kudos)

Setup

  • OS: Arch Linux
  • Python version: 3.11.7
  • beets version: 1.6.1
  • Turning off plugins made problem go away (yes/no): n/a

ArtemSmaznov avatar Feb 28 '24 22:02 ArtemSmaznov

You mean we could change the default colorscheme? yeah why not! if we can improve readability, great idea!

Please play around with the options as documented here and post some screenshots of your ideas:

https://beets.readthedocs.io/en/latest/reference/config.html#colors

JOJ0 avatar Feb 29 '24 09:02 JOJ0

Thanks, didn't realize there was a new version of the docs.

I have tried setting all to red as a test and saw that the release metadata is still white (music brains, country, label, etc.). So maybe this ticket should be a feature request to add a new config color option names something like release_metadata or the like and set it to faint? I don't think having it next to the url with the same color will be hard to read.

I am happy to review the UI afterwards to see if I can suggest any further changes, but the metadata color is my primary concern at this point.

ArtemSmaznov avatar Feb 29 '24 16:02 ArtemSmaznov