beets
beets copied to clipboard
MusicbrainzNGS replacement
Description
Suggestion for musicbrainz substitution in relation with discussion #4660
Tests have been ran with command tox -e py311-test
To Do
- [ ] Documentation. (If you've add a new command-line flag, for example, find the appropriate page under
docs/
to describe it.) - [ ] Changelog. (Add an entry to
docs/changelog.rst
near the top of the document.) - [x] Tests. (Encouraged but not strictly required.)
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Hello, it is still relevant but the merge is corrupted since the massive style conformance that was made last summer. Unfortunately I have a serious lack of availability to fix it.
However the replacement library mbzero is not sufficiently experimented and would expect some review.
To move forward, we could split this PR to prepare for a replacement and drop the last commit.
I would be happy to work on that when I have time, but if anyone wants to take the lead, it's also fine.
As musicbrainzngs is still unmaintained, I would recommend to keep that PR open
Hello, as the library mbzero evolved (test coverage got pretty good), I updated the request to match the new style.
Tests done: py312 py312-lint format format_check
Again, read commit per commit.
Suggestions are welcome
(ping @sampsyo)
Thanks for the PR! First off, I made a bunch of comments on the code but there's one issue to deal with before anything else: mbzero
requires Python 3.10, which is not the minimum-supported python version for the beets project. That would be 3.8, soon to be 3.9. We won't support 3.10 until October, 2025 at the earliest. This is why the tests are failing.
Do you have a solution to that? Because if not, this PR will have to be placed on hold until 2025-10. I see you're the maintainer for mbzero
; is there a reason that 3.10 is your MSV?
Hello,
I saw that last week. I don't think there is any blocker, 3.10 was my python version at the time of development. Let me check on 3.8 and 3.9.