beets icon indicating copy to clipboard operation
beets copied to clipboard

lyrics: Add TIDAL backend

Open jcjordyn130 opened this issue 2 years ago • 3 comments

Description

This adds a TIDAL backend to the lyrics plugin. It requires a paid TIDAL account as the free account returns 404 upon lyrics query. This feature adds a new (optional) dependency on tidalapi though. The lyrics tests completed successfully both in my personal usage and when running the test_lyrics.py file. The reasoning behind this new feature is that TIDAL lyrics have time codes (important for my usage, lyrics in the Navidrome web player require them).

To Do

  • [X] Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • [X] Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • [X] Tests. (Encouraged but not strictly required.)

jcjordyn130 avatar Jan 20 '23 05:01 jcjordyn130

I don't have a paid Tidal account to test this, but the code looks fine to me (some minor comments).

I just checked and the free version works for albums/tracks search. It may be a good idea to also create an auto-tag plugin for Tidal (which can work with a free account). Lyrics can then be easily added.

arsaboo avatar May 25 '23 01:05 arsaboo

To future-proof this, we should have a separate tidal config. In the lyrics config, users can then enable tidal by adding it as an additional source.

arsaboo avatar May 25 '23 12:05 arsaboo

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 15 '23 16:10 stale[bot]