beets icon indicating copy to clipboard operation
beets copied to clipboard

Allow mutiple operations on image file for fetchart plugin

Open vicobarberan opened this issue 1 year ago • 6 comments

Description

Fixes #4452

vicobarberan avatar Dec 26 '22 20:12 vicobarberan

Ideally, the plugin would do all the required conversions in one pass, so that it doesn't introduce quality loss for each re-encoding (and disregard the quality setting completely in some cases).

GrantMoyer avatar Feb 12 '23 17:02 GrantMoyer

Ideally, the plugin would do all the required conversions in one pass, so that it doesn't introduce quality loss for each re-encoding (and disregard the quality setting completely in some cases).

I agree. However, the current code is still a useful first step to fix the immediate issue; doing the single-pass conversion is a bigger project that requires adding this functionality in the ArtResizer first. So, I'd say it's still fine to merge this first.

wisp3rwind avatar Feb 12 '23 17:02 wisp3rwind

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 17 '23 22:06 stale[bot]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 15 '23 07:12 stale[bot]

Just checking whether @vicobarberan might be interested in doing another iteration on this PR so we can land it!

sampsyo avatar Dec 15 '23 14:12 sampsyo

I was looking at open issues to work on and came across this. Idk how I missed it when I created a similar PR a month ago to address this issue.

  • #5152

It seems to have been inactive for over a year. I respect the work done by the author of the existing PR, and I am leaving this message here just to link both of them.

To the author of the existing PR, I hope you don't mind me submitting a new PR. If you plan to update your PR, please let me know and I'd be happy to close mine.

Dr-Blank avatar Apr 14 '24 08:04 Dr-Blank