Change the option 'Remove old' -> 'Replace old' in the importer CLI

[Sciencentistguy]

Description

The CLI currently provides the following options to handle adding a duplicate album:

[S]kip new, Keep all, Remove old, Merge all?

This PR replaces the word Remove with Replace:

[S]kip new, Keep all, Replace old, Merge all?

In my opinion, this more accurately reflects what the operation does.

To Do

• [x] Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
• [x] Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
• [ ] Tests. (Encouraged but not strictly required.)

[sampsyo]

Hi! Thanks for the interesting proposal! It's true that the end effect of this option is that the old music will be replaced with the new music. I certainly don't have a strong objection, but the reason it's currently "Remove" is to suggest exactly what will happen to the old music: it's like running the beet remove command.

Anyway, it's a subtle difference, so no strong feeling either way—but maybe it would be nice to get other perspectives about what this rephrasing would mean to them.

[Sciencentistguy]

My primary disliking of the current phrasing is that "remove existing" does not immediately say to me "and import this on top of it" (i.e. replace)

[arsaboo]

The other problem (and I only realized it recently) is that "remove old" removes all the old files and not only the files being replaced. So, for example, if there are 5 tracks already in the library and you add one new track that already exists and you choose "remove old", it will delete all the 5 tracks in the library and only retain the one new track. With the current behavior (of deleting the old tracks) maybe Remove is not a bad label.

Having said that, I prefer the replace behavior, when only the duplicate tracks are replaced. Once we have that behavior, I think we should change the label.

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.