beets icon indicating copy to clipboard operation
beets copied to clipboard

Preserve mtimes from archives #4392

Open arogl opened this issue 3 years ago • 1 comments
trafficstars

Description

Fixes #X.

(...)

To Do

  • [ ] Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • [X] Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • [ ] Tests. (Encouraged but not strictly required.)

arogl avatar Jul 02 '22 05:07 arogl

Initial change

Still to do [ ] test which archive types do not keep mtimes [ ] how to check whether preserve_mtimes is set

arogl avatar Jul 02 '22 06:07 arogl

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 01 '22 15:11 stale[bot]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Still relevant.

arogl avatar Nov 01 '22 22:11 arogl

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 18 '23 11:03 stale[bot]

This should be an easy pull, as it mimics normal unzip behaviour of extracting files with times from the zip file.

Python unzip does not modify the files date when extracting, so it gets the current time.

arogl avatar Mar 18 '23 22:03 arogl

Looking good! I think all this needs is to polish the comments so they're self-contained and oriented toward the code-reader of the future rather than summarizing our discussion here, and it will be good to go.

sampsyo avatar Mar 25 '23 15:03 sampsyo

Very nice work; thanks for your effort on this!!

sampsyo avatar Apr 01 '23 22:04 sampsyo