app icon indicating copy to clipboard operation
app copied to clipboard

Runtime Detail lanes are fixed to widths in 5 minute increments

Open vincep5 opened this issue 5 years ago • 4 comments

temp The screenshot shows 2 runtimes. The first section is 17mins and the second one looks larger, but is only actually 18mins. It is noticeable on a larger screen like a laptop/desktop monitor. I understand that the 5min interval from Ecobee is the standard way they track usage. So it appears this way because the 2nd runtime ran in the last few seconds of the 5 minute interval.

Possibilities

  1. Could the graph consider the runtime and plot accordingly ?
  2. temperature_profile.php uses the 5min interval as the delta start and end time. Perhaps that should be using true runtime to better calculate the statistics.

vincep5 avatar May 29 '19 20:05 vincep5

Made some minor improvements to this. I still have some testing to do as there are some edge cases that my change breaks.

Here's what it looks like for your example: image image

ziebelje avatar May 30 '19 00:05 ziebelje

The current outstanding issue with this change is that multi-stage systems get broken up.

For example: This image Turns into this image

Which is inaccurate because it implies that the system was off between stages. This happens because the end of stage 1 is shifted to the left, and the beginning of stage 2 is shifted to the right.

One solution would be to rig the GUI to artificially shift things about. A second solution would be to enable the stage 1 graph any time stage 2 is active. Another solution is to alter the API to return the data in a different format that shows stage 1 on at the same time as stage 2, but that requires many changes to the frontend to fix all the calculations.

I think the best solution is the second, as that doesn't require any weird hacks, leaves the API alone, and would basically just be filling that blank space with the stage one color which would be the most accurate.

ziebelje avatar May 30 '19 02:05 ziebelje

Thanks for the fix! Sounds a little tricky with the 2 stage system. I'd agree don't do any weird hacks

vincep5 avatar May 30 '19 13:05 vincep5

I just want to say this issue is the worst. :)

I still plan on fixing it, though...

ziebelje avatar Jan 18 '20 03:01 ziebelje