Peter Brown

@elvanja sorry I haven't had a chance to look at this yet. It seems like this should affect any sparse field name that needs to get converted from dashes to...

I'm interested in keeping with the spec, but I'm curious what the use case would be. If JaSerializer only supports 1.0, why would you want that optional?

I'm on the fence on this one. It doesn't seem like JaSerializer is doing anything wrong by including the version and any client that consumes then JSON:API should be able...

That should work, but if there's a [`base_url` passed in](https://github.com/vt-elixir/ja_serializer/blob/master/lib/ja_serializer/builder/pagination_links.ex#L58) when generating the links, that will take precedence. If you're able to reproduce the issue with a sample app, I...

@strzibny I noticed your example app isn't using Scrivener for pagination. The `page_base_url` is only applied when using that. See https://github.com/vt-elixir/ja_serializer#scrivener-integration. For links that are not using pagination, you'll need...

@strzibny to be honest, I don't know the history of *why* JaSerializer only provides relative links but allows you to prepend pagination links. In any app I've used JaSerializer for...

I totally agree on the consistency thing. I would definitely be open to supporting the base url for non-paginated links.

@aizotov it sounds like there may be support for this in [JSON:API v1.1](https://github.com/json-api/json-api/issues/795). Once that is finalized then we'd be interested in doing something in JaSerializer. Unfortunately I haven't found...

Unfortunately with the DSL there are some reserved keywords that cause weird behavior when they are used. In this case it's an unhelpful compilation error. I've been adding more useful...

This issue isn't specific to wicked_pdf, I'm having the same problem with PDFKit. The problem didn't appear until I installed 0.11.0_rc1 via homebrew. I stumbled on this ticket while trying...