Aegis icon indicating copy to clipboard operation
Aegis copied to clipboard

Material You icon support for Aegis

Open Tqqk opened this issue 3 years ago • 1 comments

Hello, First of all I just wanted to say that I love your app guys and I would like if you would add Material You icon support for Aegis. https://developer.android.com/about/versions/13/features#themed-app-icons

Thank you

Tqqk avatar Jul 14 '22 18:07 Tqqk

Agreed. This should be fairly easy to do.

alexbakker avatar Jul 20 '22 19:07 alexbakker

Potentially related to https://github.com/beemdevelopment/Aegis/issues/842?

ChanceHarrison avatar Aug 13 '22 19:08 ChanceHarrison

Indeed. That one doesn't require a targetSdkVersion bump though, but I believe this one does (which is currently blocked by https://github.com/android/android-test/issues/1412).

alexbakker avatar Aug 14 '22 11:08 alexbakker

the blocking bug is fixed! 🙌

uniquePWD avatar Aug 26 '22 05:08 uniquePWD

Hi all 👋 I just wrote a branch to do this, but when I bumped the target SDK to 33, robolectric tests started failing. Looks like it doesn't yet support API level 33.

I'm happy to open the PR with Robolectric configured to run against API level 32, but that seems like it might defeat the purpose of tests a bit... Let me know. In the meantime, here's a sneak peek:

jas14 avatar Sep 04 '22 03:09 jas14

@jas14 Nice!

I'm not too worried about forcing the Roboelectric tests to API 32. We can switch that back later, after Roboelectric adds support for API 33.

alexbakker avatar Sep 05 '22 19:09 alexbakker

Looks amazing @jas14

uniquePWD avatar Sep 05 '22 20:09 uniquePWD

This was fixed a while back. Any insight into what needs to happen to get a version released that supports this @alexbakker ?

uniquePWD avatar Nov 01 '22 06:11 uniquePWD

@pwd-github There's now a beta release that contains this change! v2.1-beta1

alexbakker avatar Nov 02 '22 16:11 alexbakker

@pwd-github There's now a beta release that contains this change! v2.1-beta1

You're a lovely, wonderful man. Thank you so much for your continued hard work.

uniquePWD avatar Nov 02 '22 21:11 uniquePWD