TornadoVM icon indicating copy to clipboard operation
TornadoVM copied to clipboard

Improve code readbility and maintance with String Templates

Open mikepapadim opened this issue 1 year ago • 5 comments

Is your feature request related to a problem? Please describe. The feature is related to code cleanup and readability. The codebase heavily uses String concatenation for error and debug logging.

Describe the solution you'd like We can improve code readability and maintenance by replacing String manipulation with String Templates from JDK21.

Describe alternatives you've considered

Additional context

  1. https://openjdk.org/jeps/430

mikepapadim avatar Jan 11 '24 10:01 mikepapadim

Please, follow the template for feature request

jjfumero avatar Jan 11 '24 10:01 jjfumero

I would love to work on this. Can you assign it to me

shamonhashmi148 avatar Jan 14 '24 12:01 shamonhashmi148

Hi @genzarchitect , that's excellent. I suggest @mikepapadim adding a more precise description of the scope of this task. Feel free also to ask questions.

jjfumero avatar Jan 15 '24 08:01 jjfumero

I added an example PR (#312) of what is expected in the scope of this task.

I suggest going over one package at time (e.g., tornado-drivers, tornado-runtime etc), adopting String Templates were possible and opening a PR.

mikepapadim avatar Jan 18 '24 08:01 mikepapadim

@mikepapadim I understood string template changes part but Could you tell me how to start/run this repo so that after making changes i can check . Kindly let me know what are these and how to this because it was mentioned in PR(#312 )

Backend/s tested Mark the backends affected by this PR.

OpenCL PTX SPIRV OS tested Mark the OS where this PR is tested.

Linux OSx Windows How to test the new patch? make make tests

shamonhashmi148 avatar Jan 18 '24 21:01 shamonhashmi148

String templates are deprecated and removed from JDK 23. https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html

I will close this issue.

jjfumero avatar Jun 18 '24 14:06 jjfumero