beefy-v2 icon indicating copy to clipboard operation
beefy-v2 copied to clipboard

Metapool LP breakdowns

Open BrknRobot opened this issue 2 years ago • 7 comments

This adds support for metapool LP breakdowns. Any nested LPs will be replaced by it's held tokens in the display. I think it could be nice to continue showing the nested LP in our breakdown, but that was more UI work than I felt like doing.

2022-07-13T23:01:16,290757838-05:00

BrknRobot avatar Jul 14 '22 04:07 BrknRobot

looks great. what if we show underlying tokens (without am*)? can do this by enforcing "underlyingToken" property in all curvePools and then add it to API breakdown and match in app.

roman-monk avatar Jul 14 '22 07:07 roman-monk

looks great. what if we show underlying tokens (without am*)? can do this by enforcing "underlyingToken" property in all curvePools and then add it to API breakdown and match in app.

Are you proposing "underlyingToken" as a new field? I don't see a reference to that anywhere in the code. If we're adding something new, it may make more sense to add "underlyingToken" in the address-book so that we can set something up that's not just Curve specific. I could see this being helpful for wTokens for example

BrknRobot avatar Jul 15 '22 03:07 BrknRobot

new field "underlyingToken" to the lps/breakdown API. app will have to match underlyingToken || token for breakdown. those tokens are already in the address-book.

roman-monk avatar Jul 15 '22 06:07 roman-monk

I've updated the display to show the asset tree. I've also updated the token name display, it still needs some polish, but let me know what you think.

image

BrknRobot avatar Aug 27 '22 06:08 BrknRobot

This is really cool @BrknRobot.

@roman-monk wdyt?

MirthFutures avatar Aug 28 '22 19:08 MirthFutures

yeah its very nice, i still think displaying underlying tokens as we do in filters and vault names would be more user friendly than "Aave Matic Market Dai"

roman-monk avatar Aug 29 '22 12:08 roman-monk

I liked the technical detail, but you're probably right. I'll switch it over

BrknRobot avatar Aug 29 '22 17:08 BrknRobot