react-native-actionsheet icon indicating copy to clipboard operation
react-native-actionsheet copied to clipboard

Published 20 hours ago • verified publisher icon beefe

Update for getDerivedStateFromProps

Open walaman opened this issue 4 years ago • 8 comments

Trying to fix issue https://github.com/beefe/react-native-actionsheet/issues/84

Changed

  • _calculateHeight() && get styles() out of class
  • Use getDerivedStateFromProps instead of componentWillReceiveProps

walaman avatar Oct 16 '19 15:10 walaman

for me seems to work, thanks :)

EJohnF avatar Nov 08 '19 11:11 EJohnF

Could it be mergeable?

MaxInMoon avatar Jan 06 '20 16:01 MaxInMoon

will this be merged?

lukasa1993 avatar Apr 02 '20 18:04 lukasa1993

Any updates for merge?

klimdead avatar Apr 29 '20 13:04 klimdead

Thanks for the PR. Maybe @xiaoyann could merge?

pke avatar Jun 03 '20 15:06 pke

Maybe @xwenliang @skyRen @xiaoyann @chunyanzhu @penghongsun or @skinTest can merge? Thanks in advance guys, it would be great for all of us. And Thank you @walaman for your work.

Santo-dev avatar Jul 09 '20 09:07 Santo-dev

@walaman Is it possible to merge ? It would be great for all of us. Thanks in advance.

Sorry Im not the owner, and I don't have the permission to merge it. Seems this project have been abandoned and outdate, it would be better to rewrite using react hook

walaman avatar Jul 09 '20 09:07 walaman

I released the fix to npm, read #131

alessiocancian avatar Feb 21 '21 11:02 alessiocancian