helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[common] pullSecret name should be configurable

Open TobyTheHutt opened this issue 2 years ago • 1 comments

Is your feature request related to a problem? Please describe. No.

Describe the solution you'd like In the current state, the pullSecret can be turned on or off as a boolean . The name consists of the library.name variable and the suffix -registry-pull-secret, as described in the default values.yaml.

It's desirable in some use cases that the name of the secret can be set as a string.

Describe alternatives you've considered If it's in one's power, they might change the naming concept of the K8s objects according to the common Chart. Alternatively, you might swallow the pill and rename/workaround the automatically generated secret with whatever mechanisms suit you best.

Additional context -

TobyTheHutt avatar Sep 29 '23 07:09 TobyTheHutt

Hi @TobyTheHutt I think that has already been added a while ago. See: https://github.com/bedag/helm-charts/blob/master/charts/common/values.yaml#L45

nschmid avatar May 23 '24 06:05 nschmid