Matthew R. Becker comments

Results 684 comments of


                                            Matthew R. Becker

Make a PSF object type which is a call to a PIFF object

This is already done here: https://github.com/LSSTDESC/seacliff/blob/main/seacliff/rubin_psf.py

Make a PSF object type which is a call to a PIFF object

As I said before, seacliff is potentially a very natural home for SSI. imSim can pull in seacliff modules as well.

Make a PSF object type which is a call to a PIFF object

I have also done the WCS: https://github.com/LSSTDESC/seacliff/blob/main/seacliff/rubin_sky_wcs.py and the noise: https://github.com/LSSTDESC/seacliff/blob/main/seacliff/rubin_noise.py

Introduce Ruff Linter

Ah I missed that! LGTM!

Introduce Ruff Linter

I like all of the flake8 rules so I like preview mode, but that is me.

Introduce Ruff Linter

Let's wait for a few more reviews and then merge.

Introduce Ruff Linter

We have two approvals from core , so I'd be happy to merge today.

Introduce Ruff Linter

We have two test failures. After those are fixed, we can merge.

Hint about extra fields in conda-forge.yml

I don't care personally. I was trying to make sure more discussion was had since others had objected.

add default branches that are ignored by smithy for uploads

I don't care how it is phrased so happy with whatever in terms of allow vs reject lists. One vote in favor of an expanded reject list is that if...