Matthew R. Becker comments

Results 684 comments of


                                            Matthew R. Becker

Moffat maxK computation : Galsim 2.4-> 2.5

i'll have to look at the code and see what is there right now.

Moffat maxK computation : Galsim 2.4-> 2.5

we should be using more of these simple fitting functions to do parameter conversions (eg effective radius to fwhm) when creating objects in jax-galsim instead of directly solving.

Moffat maxK computation : Galsim 2.4-> 2.5

This was fixed here: https://github.com/GalSim-developers/JAX-GalSim/commit/62d146e36e422bef9824925b5cc04bc378d5a8a9 We use a full bisection to solve for the maxk value like galsim. We can close this one.

consistent wrapping for docstrings

xref: https://github.com/GalSim-developers/JAX-GalSim/issues/93

immutability in Image class

I think we solved all of the issues here. The key is that galsim `Image` objects hold their underlying data as `._array`. So we can replace that array underneath and...

validating class instantiation and jitting

I don't think there is a workaround for this that is perfect. Our tests now jit and autodiff all of the objets, so some of the checks work, but not...

validating class instantiation and jitting

Ok. I'll go through and update doc strings.

port over better k space fitter from MOF

Is this a v2 item?

port over better k space fitter from MOF

We probably need to port fitvd/shredder to v2 BTW.

port over better k space fitter from MOF

Unless we run it in mdet I suppose.