Greg Becker

We should revisit it after we have the join synchronization in place, which I think will be more complicated because we'll need to keep spill out of two nodes, probably..

Not clear to me what this buys us??? The short program name is already output with each hse log messge as well as "[HSE]", so it seems we're adding just...

If you define LOG_DOMAIN=kvset, then don't all our log messages contain kvset?

I usually just egrep for partial function names that contain the log messages I'm interested in.. This is yet another reason all functions in a module should start with the...

Ah, now I get it... Which is why I always use unique module prefix which gets your this DOMAIN functionality for free!

Alrighty then, seems to be working pretty well, what's left to do?

This patch scares the eff out of me and I don't really have the time to scrutinize is sufficiently...

You should also have seen no gc operations...

yeah, i was having issues with that when running db-bench... what stats are you looking at? in general, i don't think our stats include the garbage, which is why i...

"We used all the operator magic of modern C++ to achieve the same feeling in your code." That's kinda frightening! Why not yyjson?