mlc icon indicating copy to clipboard operation
mlc copied to clipboard

Do Not Warn for Redirects to Given Patterns

Open EagleoutIce opened this issue 1 year ago • 1 comments

As proposed in #84, this adds the new option --do-not-warn-for-redirect-to which allows to mute warnings for redirections if they lead to an URL which matches the specified pattern.

I've used my (rudimentary) understanding of Rust to implement this option roughly mirrored to the existing --ignore-links option, so feel free to suggest any kind of improvements/problems which my solution has (I hope my choice of using Arc to share the do_not_warn_for_redirect_to vector was at least not an utter failure)!

The PR includes three new tests for check_http and adds the option to the main Readme. For now, I haven't changed the CHANGELOG.md because I am not sure if I am even supposed to do that.

EagleoutIce avatar May 15 '24 21:05 EagleoutIce

I am confused, are the failing actions my fault? If so, I am really sorry - I can (locally) only test on Linux and do not really understand how the errors should be caused by my changes.

EagleoutIce avatar May 17 '24 17:05 EagleoutIce

Thanks for the PR. I don't know yet why it is failing on Windows. Will give it a try localy on Windows machine.

becheran avatar May 19 '24 19:05 becheran

CI is broken, but it is not because of this PR. Will merge and fix seperately. Thanks!

becheran avatar May 19 '24 19:05 becheran