Juho Vepsäläinen

Results 352 comments of Juho Vepsäläinen

Ok. There's likely some logic missing. I'll try to look into this once I have some time (might be weeks).

Ok, if you can PR a fix that would be great. Most likely the search algo needs a little tweak. It needs a test too (logic is fully covered by...

@Milewski Any chance for a little project to study? I have hard time figuring out the problem to fix and I can't get the fix done without.

@Milewski Cool. Thanks. The current code might capture the first case. An array of array should trip at validation (good extra test to add, though). The latter is more puzzling....

@Milewski Thanks for bringing that up. Re-opened.

It's all or nothing right now. I could accept a PR changing this if you can propose good semantics on how to handle it.

I would drop the global `disable: true` since you can handle that on configuration level. I wonder if we could do some kind of a `include`/`exclude` array instead. I'll try...

> The per entry config is basically 👍 , only concerns of mine are maintenance > used ? and performance It's actually done already. What we would do here is...

@crucialfelix Yeah, that would be a start.

> I still think a disable switch is very useful. It's easy to disable for all and then enable for the few or the one. Or enable for all and...