Alberto Chiusole

Results 31 comments of Alberto Chiusole

Regarding the double-licensed files: this is another reason to include a unique license file; when I've packaged this code as RPM I've looked around and I've only found OpenBSD licensed...

We could place a class inside the base interface class, something like: ```python class RESTInterface(..): class FormattedResponse(requests.Response): @property def formatted(self, request_response): raise NotImplementedError ``` and then each exchange interface re-implements...

Great job, @mattisback. I've contributed to your spreadsheet by adding a ticker on binance. @nlsdfnbch any idea on how to proceed? do you approve the idea of the abstract wrapper...

Great work @mattisback, just a couple of review notes on the excerpt of formatter you showed here (had no time yet to review the rest): 1. Don't use `float()` to...

2. I don't think is needed. "If it walks like a duck and it quacks like a duck, then it must be a duck." > The separate files separate out...

> What I don't understand with your method is how are multiple functions handled? For example, your code lets us format the ticker method but what about others? It's simply...

@mattisback have you already implemented something following Nils's advice? Otherwise I'm going to work on it now

I tried to implement a new version on multiple endpoints (a6832bf72737eac169c5c01ed550aa385123d747), and I created two working examples of the ticker method on bitfinex and poloniex (I'm just a bit unsure...

Since I'm working on a project, and I needed a standard way to access the ticker of many exchanges, I've implemented a dozen more exchange formatters in 0f389a6b993569e9c4ee04e006a82b0e791286b8, available inside...

> I would define some sort of default value for data which is not acquirable (the most obvious one I can think of is None or N/A or similar) and...