Why is there Linear and Circular bools on Locus struct?

Open Koeng101 opened this issue 4 years ago • 4 comments

Describe the bug In io.go at line 80 + 81, there is a Circular and Linear field, both as booleans. Couldn't you just have one? (Since if Circular is false, linear is true, and vice versa, by definition).

Is this here simply to accommodate the ambiguous case?

To Reproduce Steps to reproduce the behavior: go to io.go

Expected behavior A single field

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

Jan 17 '21 16:01 Koeng101

@TimothyStiles I can fix the cloning stuff if I have an answer to this

Jan 18 '21 23:01 Koeng101

@Koeng101 did we already solve this? Should be fixed with #227.

Dec 24 '21 14:12 TimothyStiles

Think so. Let's close.

Dec 27 '21 02:12 Koeng101

https://github.com/TimothyStiles/poly/blob/beacf5d83d54f588c154a634e9f222b27349291c/io/genbank/genbank.go#L97-L98

Heyyyyyy

Jun 26 '22 23:06 Koeng101