poly icon indicating copy to clipboard operation
poly copied to clipboard

Turn on `revive` linter in golangci config

Open carreter opened this issue 1 year ago • 1 comments

Describe the desired feature/enhancement

Seems like golangci dropped support for golint a few versions ago. IMO, we should definitely have some sort of linting enabled!

Is your feature request related to a problem?

The problem: I cannot stand unlinted codebases!

Describe the solution you'd like

Add revive, a drop-in replacement for golint, to the list of enabled linters .golangci.yml.

This will require going through the entire codebase and fixing all of the errors until just lint is happy. Running golangci-lint -c .golangci.yml run --fix will take you part of the way there. It would probably also be good to add another entry to the justfile called lint-fix that runs golangci-lint -c .golangci.yml run --fix, or allow the user to pass additional arguments to the lint target (e.g. just lint --fix).

Describe alternatives you've considered (optional)

We could just leave the linter off, but that would make me sad :(

Additional context

Add any other context or screenshots about the feature request here.

carreter avatar Feb 02 '24 21:02 carreter

This issue has had no activity in the past 2 months. Marking as stale.

github-actions[bot] avatar Apr 03 '24 18:04 github-actions[bot]