metrics icon indicating copy to clipboard operation
metrics copied to clipboard

Add Redis adapter

Open vamsiikrishna opened this issue 9 years ago • 11 comments

vamsiikrishna avatar Sep 22 '15 06:09 vamsiikrishna

First thanks for your contribution.

As there is many redis adapater in the wild (predis credis, php_redis), could you rename the Redis class to CRedis ?

lyrixx avatar Sep 22 '15 13:09 lyrixx

@lyrixx I had similar idea, but I don't think creating a new class for every redis adapter will be practical . any other approach you can recommend ?

Thanks

vamsiikrishna avatar Sep 22 '15 15:09 vamsiikrishna

I don't see any others.

lyrixx avatar Sep 22 '15 15:09 lyrixx

@lyrixx ok, will rename redis class to CRedis for now.

I will keep searching for any other ways. btw all redis libraries just need host and port to initiate the connection, that's why I asked if there is a better way.

Thanks

vamsiikrishna avatar Sep 22 '15 15:09 vamsiikrishna

Hi @lyrixx I have made necessary change . Please review

Thanks

vamsiikrishna avatar Sep 25 '15 08:09 vamsiikrishna

@vamsiikrishna Do you have time to finish your PR ?

lyrixx avatar Oct 22 '15 09:10 lyrixx

@lyrixx I will try to complete this during weekend .

Regards

vamsiikrishna avatar Oct 23 '15 05:10 vamsiikrishna

@lyrixx @stof I have added support for sf bundle and have tried to implement the changes you guys have suggested. Please review .

Thanks

vamsiikrishna avatar Oct 31 '15 05:10 vamsiikrishna

Hi @lyrixx ,

any chance you can review it again ? thanks

vamsiikrishna avatar Nov 25 '15 06:11 vamsiikrishna

@vamsiikrishna sure. But there is still pending comment that should be addressed. After that, we will be OK ;)

lyrixx avatar Nov 25 '15 09:11 lyrixx

@beberlei sorry to bother you again I had done the necessary changes , but I do have some doubts about the way I have implemented the bundle. can you please check this ?

vamsiikrishna avatar Dec 15 '15 13:12 vamsiikrishna