metrics
metrics copied to clipboard
Add Redis adapter
First thanks for your contribution.
As there is many redis adapater in the wild (predis credis, php_redis), could you rename the Redis class to CRedis ?
@lyrixx I had similar idea, but I don't think creating a new class for every redis adapter will be practical . any other approach you can recommend ?
Thanks
I don't see any others.
@lyrixx ok, will rename redis class to CRedis for now.
I will keep searching for any other ways. btw all redis libraries just need host and port to initiate the connection, that's why I asked if there is a better way.
Thanks
Hi @lyrixx I have made necessary change . Please review
Thanks
@vamsiikrishna Do you have time to finish your PR ?
@lyrixx I will try to complete this during weekend .
Regards
@lyrixx @stof I have added support for sf bundle and have tried to implement the changes you guys have suggested. Please review .
Thanks
Hi @lyrixx ,
any chance you can review it again ? thanks
@vamsiikrishna sure. But there is still pending comment that should be addressed. After that, we will be OK ;)
@beberlei sorry to bother you again I had done the necessary changes , but I do have some doubts about the way I have implemented the bundle. can you please check this ?