Benedikt Heine

Results 131 comments of Benedikt Heine

Thanks for upstreaming the patch. But sadly, as there is #191 still not fixed, It won't get merged until a new maintainer is here in rsnapshot.

Thank you, @galenseitz. Without futher testing, I can say your code looks quite clean. Your commit messages are perfect. Are you aware, that rsnapshot searches a new maintainer? #191

:+1: This looks great. Right now, every test is enhancing rsnapshots' test suite. We have 7 tests against 4000 SLOCs in `rsnapshot-program.pl`. But I have one single objection, before we...

Bit OT: there is nothing about test-cases added in `CONTRIBUTING.md`. We have to port `NOTES/add_test_case`, adapt it and maybe rewrite parts. At the end we have to put it into...

Ok, guys. I think we have to think about, what to test and how to test the whole bunch of things. I've stumbled over [a stackoverflow-thread mentioning modulinos](http://stackoverflow.com/questions/9134408/is-perl-unit-testing-only-for-modules-not-programs). What do...

You're right. This might decrease the test-coverate at the beginning, but I don't mind this in first place. Right now, my general interest is to search for a good solution...

I don't want to change the public interface either. Changing the public interface is as I imagine modulinos not neccessary. > They are at least useful regression tests even if...

--with-question='Do Makefile.PL or Build.PL have support for common options, like setting another rsync-path?'

@sam-at-github Had you been able to work on the testsuite? I'm waiting for you, to merge #74. In #74 there are tests for `cmd_preexec` and `cmd_postexec` added.

`-c` will get testsuite-support at #77. The tests are not added there yet, but they will follow.